2080610 - Remove single use inspector.xul overlays in DOMi

Status: ASSIGNED

(SeaMonkey :: General, task)

Description

[Ian Neal]

inspectorOverlay.xul and toolboxOverlay.xul are only used in inspector.xul so should probably be merged into that file.

Comment 1

[Ian Neal]

Attachment: 2080610-domi-remove-inspector-overlays-25325.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.25b1pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9657353 [details] [diff] [review]
2080610-domi-remove-inspector-overlays-25325.patch

Looks mostly good
NIT:

•  <menu id="windowMenu"/> <!-- Firefox-mac, SeaMonkey -->
  

The Firefox reference can go.

•  <menupopup id="menu_ToolsPopup"/> <!-- Mac magic -->
  

I only see this defined in browser and

• /layout/tools/layout-debug/ui/content/layoutdebug-overlay.xul

In layoutdebug-overlay.xul it is marked Firefox so I think it can go.

r/a+ either way. Can be cleaned up later.

Comment 3

[Ian Neal]

Attachment: 2080610-domi-remove-inspector-overlays-v1_1-25325.patch

[Triage Comment]
Addressing NITs, carrying forward r/a