Closed Bug 2080643 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63541 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327130

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 63541 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63541
Details from upstream follow.

Anne van Kesteren <annevk@annevk.nl> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327130

WebKit export from bug: Picking the selected option of a single-select deselects it

<pre>
Picking the selected option of a single-select deselects it

The pick an option algorithm only sets the selectedness of an option to true, so users cannot
deselect the option of a single-select, as with a native list box. Yet activating the selected
option of a base appearance single-select list box deselected it, and so did assistive technology
there. The HTML standard defines the access key of an option to pick it, or toggle it in a select
with multiple, but unless the select had a base appearance picker it went through
HTMLSelectElement::accessKeySetSelectedIndex(), which toggled it in any select. That also left the
selectedOptions collection stale, and focused and clicked the select first.

Remove the deselection from pickOrToggleOption(), and have HTMLOptionElement::accessKeyAction() and
HTMLOptionElement::setSelectedByUser() use it regardless of appearance, so that
accessKeySetSelectedIndex() can go. pickOrToggleOption() now only hides a base appearance picker.

pickOrToggleOption() still only sets the dirtiness of the option for base appearance. Picking and
toggling set it regardless of appearance, but no native user interaction sets it yet, not the
native popup nor mouse and keyboard input, so neither should the access key or assistive
technology. Setting it for all of native appearance is left for a separate change.

customizable-select-listbox-mouse-behavior.html expected the deselection, so update it.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327130">https://bugs.webkit.org/show_bug.cgi?id=327130</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 3 subtests

Status Summary

Firefox

OK : 1[GitHub] 5[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 2[GitHub]
FAIL : 2[GitHub] 13[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 18[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 2
NOTRUN : 2

Chrome

OK : 2
PASS : 3
FAIL : 4

Safari

OK : 2
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.