Closed Bug 2081117 Opened 1 month ago Closed 29 days ago

Do not read the declarative push data after moving it in ParseDeclarativePushAndShowNotification

Categories

(Core :: DOM: Push Subscriptions, defect)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox158 --- unaffected
firefox159 --- wontfix
firefox160 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 external file)

Coverity CID 1702918 (Using a moved object).

ParseDeclarativePushAndShowNotification in dom/push/Declarative.cpp passes declarativePush to RecordTelemetry after moving it into GetNotificationOptionsForDeclarativePush. RecordTelemetry only reads the mutable_ flag, which the move leaves intact, so there is no bug today, but any field it reads later would already be gone. Read the flag before the move and pass it to RecordTelemetry.

Came from bug 2071417 and bug 2074266.

Type: task → defect
Keywords: regression
Regressed by: 2071417, 2074266

RecordTelemetry was given declarativePush after it had been moved into
GetNotificationOptionsForDeclarativePush. It only reads the mutable_
flag, which the move leaves alone, but any field it might read later
would already be gone. Capture the flag before the move.

Assignee: nobody → sledru
Status: NEW → ASSIGNED
Severity: -- → S3
Pushed by sledru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/406d8fbf1a45 https://hg.mozilla.org/integration/autoland/rev/c783ebff2ac5 Read the mutable flag before moving the declarative push data (Coverity CID 1702918) r=saschanaz
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: