Closed Bug 2081128 Opened 1 month ago Closed 1 month ago

[firefox-devtools-mcp] Reject unsafe commands for sessions restricted to a single container

Categories

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

enhancement
Points:
2

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [webdriver:m22])

Attachments

(1 external file)

Bug 2072964 restricts WebDriver BiDi sessions to the dedicated container (remote-control-container), behind the hidden pref remote.experimental.dynamicstart.container-isolation-enabled.

The browser module still lets such a session reach beyond the dedicated container. For a session restricted to a single user context:

  • browser.getUserContexts should return only the session's user context (we could also reject, but it seems harmless to keep this working)
  • browser.createUserContext and browser.removeUserContext should throw unsupported operation, it doesn't make sense to allow modifying containers if you are restricted to only one container.
  • browser.close should throw unsupported operation. It would close tabs outside the container.
Summary: [firefox-devtools-mcp] Update browser commands for sessions restricted to a single container → [firefox-devtools-mcp] Reject unsafe commands for sessions restricted to a single container
Attachment #9661160 - Attachment description: Bug 2081128 - [bidi] Update browser module commands for sessions restricted to a single container → Bug 2081128 - [bidi] Reject unsafe commands for container-restricted sessions
Attachment #9661160 - Attachment description: Bug 2081128 - [bidi] Reject unsafe commands for container-restricted sessions → WIP: Bug 2081128 - [bidi] Reject unsafe commands for container-restricted sessions
Attachment #9661160 - Attachment description: WIP: Bug 2081128 - [bidi] Reject unsafe commands for container-restricted sessions → Bug 2081128 - [bidi] Reject unsafe commands for container-restricted sessions
Pushed by jdescottes@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a109c98ffa47 https://hg.mozilla.org/integration/autoland/rev/3a1aaa02e27b [bidi] Reject unsafe commands for container-restricted sessions r=webdriver-reviewers,Sasha
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: