2081195 - re-enable vcs data ingestion in perfherder

Status: NEW

(Tree Management :: Perfherder, task)

Description

[Julien Cristau [:jcristau]]

Tasks output timings from the vcs clone in their logs, but since bug 1692409 treeherder/perfherder has been ignoring that data. So far it's still being ingested into bigquery via taskclusteretl's own log parsing, however that is going away soon (https://mozilla-hub.atlassian.net/browse/SVCSE-4220), and I'd like to keep the ability to query that information.
It's possible enough has changed since bug 1692409 that treeherder could now cope with that data? If not, we may have to resort to something like bug 2077233 (independently ingesting those same perfherder-data artifacts).

Comment 1

[Greg Mierzwinski [:sparky]]

I agree, I think enough has changed since it was disabled and we should be able to at least try re-enabling the vcs framework. I'll make a quick patch to do this.

Comment 2

[Greg Mierzwinski [:sparky]]

:jcristau, do you know if alerting is disabled for vcs metrics or is alerting needed for them? There should be a shouldAlert: False setting in the perfherder-data being produced at the suite-level and in the subtests if it's disabled. If that's not there, then it would start triggering alerts.

Comment 3

[Julien Cristau [:jcristau]]

Alerting isn't needed.
https://searchfox.org/version-control-tools/rev/5ffbbc0d67a1d60cd1b5cd87ec9ce9e9fd288e5b/hgext/robustcheckout/__init__.py#372 sets "shouldAlert": False.

Comment 4

[Julien Cristau [:jcristau]]

Anything blocking trying this out? (With taskclusteretl going away by the end of the year it would be good to know ahead of time if we can do this or if I need to work on plan B.)