[Huawei] When rotating the device, the menu becomes scrollable also on portrait mode
Categories
(Focus :: General, defect)
Tracking
(firefox158 unaffected, firefox159 verified, firefox160 verified)
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | unaffected |
| firefox159 | --- | verified |
| firefox160 | --- | verified |
People
(Reporter: mlobontiuroman, Assigned: petru)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 2 external files)
|
7.18 MB,
video/mp4
|
Details |
Steps to reproduce
- Open Focus Nightly 160.0a1.
- Open a page, and tap on the three-dot menu.
- Turn the device into landscape mode.
- Turn the device back into portrait mode.
- Observe the menu.
Expected behavior
The menu is displayed at all times. When in portrait mode is not scrollable, when in landscape mode becomes scrollable.
Actual behavior
The menu is displayed at all times. After returning from landscape mode to portrait mode it becomes scrollable.
When opening the menu in portrait mode, the menu is fixed, non-scrollable.
Device information
- Focus version: Nightly 160.0a1 from 10/13
- Android device: Huawei Pura 70 (Android 12)
Any additional information?
- not reproducible on Samsung Galaxy S24 (Android 16), Oppo Find N2 Flip (Android 15)
Comment 1•1 month ago
|
||
Set release status flags based on info from the regressing bug 2074348
:petru, since you are the author of the regressor, bug 2074348, could you take a look?
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 2•1 month ago
|
||
@Mira Since this is a device specific issue I'm curious if on the same device the old menu had this issue also?
| Reporter | ||
Comment 3•1 month ago
|
||
Hi Petru,
The issue is not reproducible with Focus Nightly 159.0a1 from 10/1 with the same Huawei device.
| Assignee | ||
Comment 4•1 month ago
|
||
Stop using the LocalWindowInfo.current.containerSize cached window size.
Take the menu height cap from the constraints the popup is measured with,
which reflect the visible frame of the app window on every measure.
Updated•1 month ago
|
| Assignee | ||
Comment 5•1 month ago
|
||
Confirmed with Mira that the above patch fixes the issue on her device.
Comment 8•1 month ago
|
||
The patch landed in nightly and beta is affected.
:petru, please make an uplift decision for beta:
- For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set
status-firefox159towontfixif the fix can wait for the next release.
See Requesting an Uplift for documentation on how to request an uplift.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 9•29 days ago
|
||
Stop using the LocalWindowInfo.current.containerSize cached window size.
Take the menu height cap from the constraints the popup is measured with,
which reflect the visible frame of the app window on every measure.
Original Revision: https://phabricator.services.mozilla.com/D334213
Updated•29 days ago
|
Comment 10•29 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Stabilize a recent UI refactor: showing a new menu layout. On some Huawei devices the menu could've had wrong dimensions after the screen is rotated.
- Code covered by automated testing?: no
- Fix verified in Nightly?: no
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2081270#c0
- Risk associated with taking this patch: low
- Explanation of risk level: Small change witht he issue confirmed as fixed by the reporter (QA).
- String changes made/needed?: --
- Is Android affected?: yes
| Assignee | ||
Updated•29 days ago
|
Updated•28 days ago
|
Updated•28 days ago
|
Comment 11•28 days ago
|
||
| uplift | ||
| Reporter | ||
Comment 12•26 days ago
|
||
Verified as fixed on the Focus for Android beta 159.0b5 and on Nightly 160.0a1 with the Huawei Pura 70 (Android 12).
Description
•