Closed Bug 2081501 Opened 1 month ago Closed 1 month ago

[performance tests] Raptor still treats Fission as off by default on Android

Categories

(Testing :: Raptor, task)

task
Points:
2

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: owlish, Assigned: owlish)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group6])

Attachments

(1 external file)

Android has had Fission enabled by default for some time - bug 2079548 made it the only geckoview-junit configuration, and bug 2078920 removes the -nofis variant from the Android performance tests. Two places in Raptor still assume the opposite.

  1. mach raptor forces Fission off on Android

testing/raptor/mach_commands.py:

# Disable fission until geckoview supports fission by default.
# Need fission on Android? Use (--setpref fission.autostart=true)
kwargs["fission"] = False

GeckoView now does support Fission by default, so the stated condition has been met. With the -nofis variant gone, CI runs Android performance tests with Fission while a local mach raptor run disables it, so a developer reproducing a CI result locally measures a different configuration.

  1. --enable-fission-mobile is a no-op

testing/raptor/raptor/cmdline.py defines the flag with dest="fission_mobile" and help text describing it as a "Temporary work-around to enable fission on mobile as it is enabled by default for desktop now but not mobile."

Nothing reads fission_mobile. The only other references in the tree are in testing/raptor/test/test_cmdline.py, which asserts the default value, so those tests pass regardless of whether the flag does anything. Passing --enable-fission-mobile has no effect, and the work-around it describes is no longer needed.

Note that --disable-fission itself should stay. No taskcluster config passes it to raptor or perftest any more, but it remains a working option for local runs.

These two items could be split if the first needs a separate decision about what local runs should measure.

Blocks: 2068254
Severity: -- → N/A
Type: defect → task
Points: --- → 5
Summary: Raptor still treats Fission as off by default on Android → [performance] Raptor still treats Fission as off by default on Android
Whiteboard: [fxdroid][group6]
Summary: [performance] Raptor still treats Fission as off by default on Android → [performance tests] Raptor still treats Fission as off by default on Android
Points: 5 → 2
Assignee: nobody → bugzeeeeee
Status: NEW → ASSIGNED
Pushed by istorozhko@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b83893d53c01 https://hg.mozilla.org/integration/autoland/rev/a1728b13d450 Stop treating Fission as off by default on Android in Raptor r=perftest-reviewers,sparky
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: