2081609 - [customizable menu] Different behavior when fetching addons recommendations fails

Status: RESOLVED FIXED

(Firefox for Android :: Menu, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Claude reported issue: if the add-on recommendations come back empty, the row says "No extensions enabled" instead of "Try a recommended extension"; if fetching them fails, you get an expandable row containing only "Discover more extensions.

Neither case is a regression from the legacy menu, and the two menus only differ in the second one. Here's what each does today:

• empty recommendations. In the legacy MenuDialogFragment.getExtensionsMenuItemDescription, the isAllWebExtensionsDisabled check comes before the "Try a recommended extension" one. allWebExtensionsDisabled in MenuState is true when there are no recommendations, no enabled extensions and nothing offered for the page. So the legacy menu also says "No extensions enabled" here. In the new menu, hasNothingToShow in ExtensionsMenuItemProvider gives the same result.
• Fetching fails. The legacy MenuDialogMiddleware only logs the error, so recommendations stay empty and the menu shows the same "No extensions enabled" item. In the new provider, resolveExtensions() returns without setting hasCheckedExtensions, so the row stays in its loading state. That state is expandable and contains only "Discover more extensions". This was a deliberate choice when working on the new menu but wasn't approved and since it's a difference from the legacy menu it should be reverted.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2081609 - Update extensions UX when fetching recommendations fails r=#android-reviewers

When fetching recommendations fails the Extensions row now behaves like
in the legacy menu: it shows "No extensions enabled" as a plain row with
the settings button, and tapping it opens the extensions manager.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b89b64e7729
https://hg.mozilla.org/integration/autoland/rev/944e0ff91a7d
Update extensions UX when fetching recommendations fails r=android-reviewers,giorga

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/944e0ff91a7d