[customizable menu] List menu items should use a dynamic inner padding
Categories
(Firefox for Android :: Menu, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: petru, Assigned: petru)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-core])
Attachments
(1 external file)
Most legacy rows are drawn by MenuItem in Fenix's MenuItem.kt. It uses IconListItem without overriding contentPaddingListItem, so the row gets the default from IconListItem:
PaddingValues(
horizontal = FirefoxTheme.layout.space.dynamic200,
vertical = FirefoxTheme.layout.space.static150,
)
dynamic200 is 16dp for AcornSpace.Small and 24dp for AcornSpace.MediumLarge, which applies once the window is at least 600dp wide (AcornWindowSize.Medium). That covers tablets and most phones in landscape.
For the new menu MenuListItem pads with AcornTheme.layout.space.static200, a fixed 16dp at every window size. ExpandableHeaderItem does the same, so the "More" and Extensions headers also stay at 16dp.
=> We should use dynamic200 for the inner padding to ensure parity with the legacy menu UI.
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
This will ensure matching the legacy menu UX for the majority of its menu items.
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
Description
•