Closed Bug 2081612 Opened 1 month ago Closed 1 month ago

[customizable menu] List menu items should use a dynamic inner padding

Categories

(Firefox for Android :: Menu, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

Most legacy rows are drawn by MenuItem in Fenix's MenuItem.kt. It uses IconListItem without overriding contentPaddingListItem, so the row gets the default from IconListItem:

PaddingValues(
    horizontal = FirefoxTheme.layout.space.dynamic200,
    vertical = FirefoxTheme.layout.space.static150,
)

dynamic200 is 16dp for AcornSpace.Small and 24dp for AcornSpace.MediumLarge, which applies once the window is at least 600dp wide (AcornWindowSize.Medium). That covers tablets and most phones in landscape.

For the new menu MenuListItem pads with AcornTheme.layout.space.static200, a fixed 16dp at every window size. ExpandableHeaderItem does the same, so the "More" and Extensions headers also stay at 16dp.

=> We should use dynamic200 for the inner padding to ensure parity with the legacy menu UI.

Assignee: nobody → petru
Status: NEW → ASSIGNED

This will ensure matching the legacy menu UX for the majority of its menu items.

Whiteboard: [fxdroid][android-core]
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/93665fd4b3d8 https://hg.mozilla.org/integration/autoland/rev/d203c4886a01 Use dynamic200 for the inner padding of list menu items r=android-reviewers,giorga
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: