2081670 - Only read the onboarding completed timestamp when the privacy report notification is available

Status: ASSIGNED

(Firefox for Android :: Experimentation and Telemetry, task, P3)

Description

[twhite]

In PrivacyReportNotificationScheduler.updatePrivacyReportNotificationWorker, settings.onboardingCompletedTimestamp is read before the notification availability check, even though the value is only used in the AVAILABLE branch.

The read goes through a longPreference delegate, so it is a SharedPreferences lookup that is wasted whenever the notification is unavailable (permission denied, channel blocked, etc.) and the worker is simply cancelled.

Move the read inside the AVAILABLE branch so it only happens when the value is needed. No behavior change.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-firefox/firefox] Bug 2081670 - [refactor] move onboardingCompletedTimestamp inside the block where it is used to prevent redundant setting. (#391)

(via GitHub webhook, authenticated as shared-secret)