20817 - Imported Cyrillic bookmarks does not convert correctly

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Eugene Savitsky]

In bookmarks so in bookmark toolbar (read: everywhere) cyrillic is displayed not
correctly. It is displayed without codepage decoding (I do not know how to
explain it in other words).

Comment 1

[Steve Lamm]

I am not sure who whould own this. Robert, do you know?

Comment 2

[Robert John Churchill]

I'd guess one of the I18N guys... ?

Comment 3

[Steve Lamm]

Reassigning to i18n.

Comment 4

[Frank Tang]

Is this a problem w/ newly added bookmark (added by using
SeaMonkey) or a problem with display you old bookmark?
What is your configuration (win95/98/NT ? what is the language version of your
OS?)
I cannot reproduce this problem w/ my newly added bookmark. I try the following
1. use SeaMonkey to visit http://ww.multifood.ru/
2. after the page load select "Bookmark:Add Current Page"
3. select the "Bookmark" menu again, you should see the correct russian display
in the bottom of that menu
4. Quit SeaMonkey
5. Lanuch SeaMonky again and repeate 3, it is still display correctly.

Can you try the same procedure ? Do you have problem in your machine? If not but
you have other problem, can you give reproduce procedure to us ? (List URL
please).

Comment 5

[Eugene Savitsky]

OK, it works.

The problem appears with imporped bookmarks from my 4.7.

I use Win98 SE RUS.

Comment 6

[Frank Tang]

So... the problem is the bookmark migration have problem.
Did you just use SeaMonkey to import the bookmark file ?

Waterson, in your bookmark migration code, have you call my nsIPlatformCharset
with kPlatformCharsetSel_4xBookmarkFile to get back the 4.x bookmark charset and
convert to the new UTF-8 bookmark file ? That function should return the correct
charset depend on the user's system (for ezh, since he is using Win98 SE RUS, he
should to got a "x-windows-1251" ) Waterson- in your system,  you should got a
"x-windows-1252"

Change the summary to "Imported Cyrillic bookmarks does not convert correctly".
reassign to waterson.
Waterson- let me know if you need any help.

Comment 7

[Chris Waterson]

to rjc

Comment 8

[Robert John Churchill]

I'll take a look-see.

Comment 9

[Robert John Churchill]

Attachment: Proposed fix

Comment 10

[Robert John Churchill]

Frank, I've attached a diff of a proposed fix. Would you try it out for me?  Just
apply the diff, then rebuild mozilla/xpfe/components/bookmarks, and finally try
using an imported bookmark file.

By the way, shouldn't

#define NS_IPLATFORMCHARSET_CID \
{ 0x84b0f182, 0xc6c7, 0x11d2, {0xb3, 0xb0, 0x0, 0x80, 0x5f, 0x8a, 0x66, 0x70 }} ;

be in "nsIPlatformCharset.h" ?

Comment 11

[Robert John Churchill]

(Minus the trailing semicolon, of course.)

Comment 12

[Frank Tang]

forgive for my bad question. How to ask SeaMonkey to import bookmark these days
?

Comment 13

[Eugene Savitsky]

Try to install build with installer...

BTW. When first builds with profile migration was availeble my personal toolbar
migrated to personal toolbar in mozilla, now it migrates to "imported IE
fovorites". I have IE but do not use them...

Comment 14

[Robert John Churchill]

Frank, probably the easiest thing for you is to just copy your 4.x bookmark file
into your existing Mozilla profile directory. Then, run Mozilla and see what you
get.

(We don't do anything special at migration time... its done every time at
startup. The procedure: we start out by using the 4.x platform native charset,
but we adjust the charset dynamically if the bookmark file tells us to. Since we
write out UTF-8 indicate it by adding a META charset tag in the bookmark file,
this should work just dandy.)

Comment 15

[Frank Tang]

I can reproduce the same problem w/ Japanese w/o your patch and it import the
Japanese bookmark correctly after I apply your patch. It work nicely. I believe
your patch will solve the Cyrillic problem also. I also reviewed your code. The
only thing about the patch is you should use NS_WITH_SERVICE instead of calling
the service manager. Good work.

Comment 16

[Robert John Churchill]

Many thanks for verifying this for me, Frank.

I'm going to reassign this bug to you so that you can add a
NS_IPLATFORMCHARSET_CID to the appropriate spot in "nsIPlatformCharset.h".

Fix (for the default charset usage) checked in.

Comment 17

[Robert John Churchill]

Fixed.

Comment 18

[Frank Tang]

I have no idea why rjc ask me to tight a CID w/ a interface file.
Interface should not tight w/ a specific CID. CID is for class, not interface.
Mark it fix since the origional problem is gone.

Comment 19

[Robert John Churchill]

Frank, I see that you figured it out.  Great!  Thanks!

http://cvs-mirror.mozilla.org/webtools/bonsai/cvsview2.cgi?diff_mode=context&whi
tespace_mode=show&subdir=mozilla/intl/uconv/public&command=DIFF_FRAMESET&file=ns
IPlatformCharset.h&rev1=1.9&rev2=1.10&root=/cvsroot

Comment 20

[Claudius Gayle]

could the reporter, [e-mail] please check to see if this now works for you and note it in this bug report?
In essence, I'm asking you to verify this bug for me/us, thanks in advance.

Comment 21

[Eugene Savitsky]

OK, but now the install builds do not import my preferences from 4.xx :(

How can I make it manually?

Comment 22

[Claudius Gayle]

Ok I'm going to mark this VERIFIED per reporter's comments. What you have is a new, or at least different bug.
I would suggest searching bugzilla for bugs in the 'Profile Migration' or possibly 'Prefs UI' components before filing
a new bug.