Skip cache-based override construction in the frame and sizing overloads of AnchorPosResolutionParams::From() when the supplied cache is null or the frame is in flow. Preserve the existing helper for other cases and clear only the position-area flag when
Categories
(Core :: Performance: Automated Findings, defect)
Tracking
()
People
(Reporter: perf-ai-bot, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [foofrix:5242d876-8f53-4b1c-84a8-996ed55d4464])
Attachments
(1 external file)
Skip cache-based override construction in the frame and sizing overloads of AnchorPosResolutionParams::From() when the supplied cache is null or the frame is in flow. Preserve the existing helper for other cases and clear only the position-area flag when aIgnorePositionArea is set. Reported measurements do not establish an end-to-end performance gain.
Problem
The frame and sizing factories unconditionally used the out-of-line cache-based constructor even when its helper would return all-false flags for a null cache or an in-flow frame. This added avoidable call overhead to common reflow and intrinsic-sizing paths. The cache requirement does not apply to the separate computed-style overload, which derives override flags from stored anchor references.
Performance
- Benchmark: speedometer4-responsive-design
- Test: sp4-responsive-design
- Component: Layout
- Local Improvement: 0.73%
Validation
| Reporter | ||
Updated•1 month ago
|
| Reporter | ||
Comment 1•1 month ago
|
||
Please move this bug to the correct component.
Once the Phabricator patch is ready for review, please commandeer it.
| Reporter | ||
Comment 2•1 month ago
|
||
Skip cache-based override construction in the frame and sizing overloads of AnchorPosResolutionParams::From() when the supplied cache is null or the frame is in flow. Preserve the existing helper for other cases and clear only the position-area flag when
Description
•