Closed Bug 2082301 Opened 1 month ago Closed 1 month ago

Focus content crash page has broken styling for the toolbar

Categories

(Focus :: General, defect)

All
Android
defect

Tracking

(firefox158 wontfix, firefox159 wontfix, firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox158 --- wontfix
firefox159 --- wontfix
firefox160 --- fixed

People

(Reporter: jonalmeida, Assigned: mcarare)

Details

Attachments

(2 files, 1 external file)

Steps to reproduce

  1. Have a tab open in Focus.
  2. Simulate a content crash with about:crashcontent.
  3. Observe

Expected behaviour

The toolbar continues to follow the same theming and styling it had.

Actual behaviour

The toolbar theming and styling is broken - the buttons are also not noticeable.

Device information

  • Focus version: 160.a1
  • Android device model: Pixel 8a, Emulator API 36
  • Android OS version: Android 16

Any additional information?

See attached video of Focus 158 (release) where the crashed tab reloads vs what I now see in Focus 160 (Nightly).

:jonalmeida, does this reproduce for you in Focus 159 beta?
:petru, Bug 2074348 looks like a potential regressor here. Setting it now, but we can update later if needed.

Flags: needinfo?(petru)
Flags: needinfo?(jonalmeida942)
Regressed by: 2074348

Bug 2074348 landed on October 5th.
Testing with this build from October 3rd l I see the same issue so the two seem unrelated.

Flags: needinfo?(petru)
No longer regressed by: 2074348

The issue reproduces in Release 157.0.1 from PlayStore also.

Adding my own recording showing the issue in 157 also.

I think it's much older than that.

The page may have always been like this on Focus. It never followed the theme?
https://github.com/mozilla-firefox/firefox/commit/52ea0edcc4ce
We can clear the regression keyword if confirmed

Also improve theming for crash fragment.

Assignee: nobody → mcarare
Status: NEW → ASSIGNED
Flags: needinfo?(jonalmeida942)
Pushed by jonalmeida942@gmail.com: https://github.com/mozilla-firefox/firefox/commit/5a357839f82b https://hg.mozilla.org/integration/autoland/rev/2b63e22088db Fix crash fragment layout positioning related to the toolbar. r=android-reviewers,jonalmeida
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: