Closed
Bug 2082391
Opened 1 month ago
Closed 26 days ago
[customizable menu] Fenix navigation to the "Customize menu" screen from long pressing on the browser menu
Categories
(Firefox for Android :: Menu, task)
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: petru, Assigned: giorga)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-core])
Attachments
(1 external file)
Whenever the user long presses on the browser menu Fenix should navigate to FenixCustomizeMenuFragment - empty for now.
class FenixCustomizeMenuFragment : CustomizeMenuFragment() {
override val menuStore = buildMenuStore()
}
In Jetpack Compose, the pointer input system naturally handles hit testing from the top (inner-most child) down to the bottom (outer parent). Since your button is on top of the layout container, it will intercept and consume the long-click event first, preventing the screen-wide container from triggering its own action.
Box(
modifier = Modifier
.fillMaxSize()
.pointerInput(Unit) {
// Captures long clicks anywhere on the screen
detectTapGestures(
onLongPress = {
println("Screen-wide long click triggered!")
}
)
},
)
** To decide whether to support the long press gesture to open FenixCustomizeMenuFragment we should check the new feature flag added in bug 2082389.
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Assignee: nobody → giorga
| Assignee | ||
Comment 1•1 month ago
|
||
Pushed by giorga@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/83d719586738
https://hg.mozilla.org/integration/autoland/rev/ecbc2927e2d4
[customizable menu] Fenix navigation to the "Customize menu" screen from long pressing on the browser menu. r=android-reviewers,android-l10n-reviewers,parker,android-build-system-reviewers,mcarare,petru
Comment 3•26 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 26 days ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•