Closed Bug 2082517 Opened 1 month ago Closed 2 days ago

Make “Secure connection” row tappable and open the sub-page

Categories

(Firefox for Android :: Settings, task)

All
Android
task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: lmccracken, Assigned: lmccracken)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-activation-trust])

Attachments

(1 external file)

Summary
Make “Secure connection” in the Trust Panel open the certificate details sub-page

Description
In the Trust Panel, the “Secure connection” row currently shows connection status but does not lead anywhere. This ticket makes the row tappable and wires it to open the certificate details sub-page. Returning from the sub-page is covered separately in a different ticket.

The row should look and behave like a standard navigable item: a clear tap target, pressed and focus states, and a visual cue (such as a chevron) that it leads to another screen, if Figma specifies one. The tap should open the sub-page for the current tab’s site and nothing else.

The row should only be interactive when there is something to show. For pages with no certificate (for example HTTP or internal pages), whether the row is tappable, disabled or hidden depends on the edge-state decisions, so build the row so that behaviour is easy to change.

In scope

Making the “Secure connection” row clickable, with a click handler
Navigation action from the Trust Panel to the certificate details sub-page, following the existing navigation approach (Navigation component, Compose navigation or the Trust Panel’s own mechanism)
Pressed, focused and ripple states, and a chevron or other affordance per Figma
Minimum touch target size (48dp)
Passing the current tab or session identifier to the sub-page, so it shows the right site
Accessibility: the row announces as a button or link with a clear action description in TalkBack
Telemetry, if the team wants a Glean event for opening the page (confirm; see open questions)
Unit or UI test that tapping the row navigates to the sub-page

Out of scope

Back navigation and state preservation
Sub-page layout and content
Data plumbing
Final behaviour of the row on HTTP, invalid or expired certificates
QWAC indicator
Pref gating, although the row may need to respect it (see open questions)
Focus

Acceptance criteria

Tapping “Secure connection” opens the certificate details sub-page for the current tab’s site.
The row has a visible pressed state and a touch target of at least 48dp.
The row shows the navigation affordance specified in Figma, in light and dark themes.
TalkBack announces the row as actionable and describes where it leads.
The row is operable with keyboard and switch access (focusable, activates on Enter or Space).
Rapid repeated taps open only one instance of the sub-page.
The Trust Panel’s other rows and behaviour are unchanged.
A test covers the tap-to-navigate path.
Behaviour on pages with no certificate is documented in the ticket as interim, and linked to the edge-states work.

Whiteboard: [fxdroid][android-activation-trust]

Adds the "Secure connection" link from Figma to the Trust Panel header. When the
QWAC UI is enabled, it replaces the connection security row, so the certificate
details are only opened from one place. Until the behaviour for pages without a
certificate is decided, the link is only shown on secure pages with a certificate.
Going back from the sub-page returns to the Trust Panel instead of dismissing it.
The "Verified by" slot is filled once D342239 lands.

Assignee: nobody → lmccracken
Status: NEW → ASSIGNED
Pushed by lmccracken@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c2749a2ff997 https://hg.mozilla.org/integration/autoland/rev/2523a14e1386 Open the certificate details sub-page from the Trust Panel header. r=android-reviewers,android-l10n-reviewers,twhite,flod
Status: ASSIGNED → RESOLVED
Closed: 2 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: