Closed Bug 2082871 Opened 1 month ago Closed 26 days ago

20.46 - 4.48% tsvgx + 2 more (Linux, OSX, Windows) regression on Tue October 13 2026

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox158 --- unaffected
firefox159 --- unaffected
firefox160 --- fixed

People

(Reporter: performance-sheriff-bot, Assigned: nical)

References

(Regression)

Details

(4 keywords)

Attachments

(1 external file)

Perfherder has detected a talos performance regression from push b7afb0e60a503e130147a4eaa919f68d952386af. As author of one of the patches included in that push, we need your help to address this regression.

Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

Regression Test Platform Options Absolute values [old vs new]
20% tsvgx (doc) linux2404-64-shippable e10s fission stylo webrender 165.41 -> 199.26
10% tsvgx (doc) macosx1500-aarch64-shippable e10s fission stylo webrender 89.00 -> 97.98
4% tsvgx (doc) windows11-64-24h2-shippable e10s fission stylo webrender 121.40 -> 126.84
Improvement Test Platform Options Absolute values [old vs new]
14% tsvgx (doc) windows11-64-24h2-shippable e10s fission stylo webrender-sw 152.65 -> 131.55
12% tsvgx (doc) linux2404-64-shippable e10s fission stylo webrender-sw 244.51 -> 215.48

Support & Actionable Steps

For questions, please contact fbilt@mozilla.com. You can also find help on Slack (#perf-help) or Matrix (#perftest).

Action guide details:

Flags: needinfo?(nical.bugzilla)

Set release status flags based on info from the regressing bug 2070993

Bug 2070993 accidentally caused that particular benchmark to render the rotating images in the blob instead of using WR. I have a fix that I'm verifying.

Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)

Bug 2070993 kept the children of a rotated or skewed transform in the blob
image unless they had to be active. This moved rotated <image> elements into
the blob and regressed tsvgx (hixie-004).

Only strokes and rounded fills need to stay in the blob under such transforms:
WebRender currently renders solid rounded rects and borders axis aligned and
then rotates them, which makes their edges blurry. The axis aligned requirement
is now passed down to SVGGeometryFrame, which applies it to those shapes only.

The non-uniform scale restriction is removed along with the
gfx.webrender.svg-images.non-uniform-scale pref. The anti-aliasing issues it
worked around were fixed by the migration from brush shaders to quad shaders.

Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5d5cda32caca https://hg.mozilla.org/integration/autoland/rev/1fe1150cdc70 Revert "Bug 2082871 - Let rotated SVG images and plain rects be drawn by WebRender again. r=emilio" for causing reftest failures in text-simple.svg

Backed out for causing reftest failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/webrender/text-simple.svg == layout/reftests/svg/webrender/text-simple.svg | image comparison, max difference: 255, number of differing pixels: 13010
Flags: needinfo?(nical.bugzilla)
Flags: needinfo?(nical.bugzilla)
Status: NEW → RESOLVED
Closed: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Regressions: 2086215
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: