Closed Bug 2082875 Opened 1 month ago Closed 1 month ago

Remove `browser.nova.enabled=false` coverage from about:debugging tests

Categories

(DevTools :: about:debugging, task)

task

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: sclements, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_profiler_dialog.js

The pref is going to be locked in Bug 2082521, so setting it to false won't work anymore.
We can remove the whole task that was checking that the performance panel is reacting
to the pref change.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Correction, bug 2082898 is the pref locking bug :)

(In reply to Sarah Clements [:sclements] from comment #2)

Correction, bug 2082898 is the pref locking bug :)

erf, thanks!

Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/81fb8f65c5ef https://hg.mozilla.org/integration/autoland/rev/b2e552f2167a [devtools] Remove Nova checks in browser_aboutdebugging_profiler_dialog.js. r=devtools-reviewers,bomsy.
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: