2082881 - Remove `browser.nova.enabled` check in debugger tests

Status: NEW

(DevTools :: Debugger, task)

Description

[Sarah Clements [:sclements]]

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

• devtools/client/debugger/test/mochitest/browser_dbg-editor-horizontal-scroll.js

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

No prefs are set for this test https://searchfox.org/firefox-main/rev/751f5671de2d327ff436154dfca6ed1733809163/devtools/client/debugger/test/mochitest/browser_af.toml#141-145

["browser_dbg-editor-highlight.js"]

["browser_dbg-editor-horizontal-scroll.js"]

["browser_dbg-editor-mode.js"]

and we're only reading from the pref in it https://searchfox.org/firefox-main/rev/751f5671de2d327ff436154dfca6ed1733809163/devtools/client/debugger/test/mochitest/browser_dbg-editor-horizontal-scroll.js#11-13

const toolboxBorderWidth = Services.prefs.getBoolPref("browser.nova.enabled")
  ? 2
  : 0;

(that's actually the only reference to the pref in the debugger folder, see https://searchfox.org/firefox-main/search?q=browser.nova.enabled&path=devtools%2Fclient%2Fdebugger&case=true&regexp=false)

So I'm not sure we don't need to do anything here? I guess we'd have to cleanup the test once the pref is effectively removed.

Am I missing something Sarah?

Comment 2

[Sarah Clements [:sclements]]

Yeah, if its not setting the pref to false in the test that should be fine to keep for now.