Open Bug 2082882 Opened 1 month ago Updated 21 days ago

Remove `browser.nova.enabled` check in DevTools tooltip tests

Categories

(DevTools :: General, task)

task

Tracking

(Not tracked)

People

(Reporter: sclements, Unassigned)

References

Details

Bug 2082521 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • devtools/client/shared/test/browser_html_tooltip-05.js
  • devtools/client/shared/test/browser_html_tooltip_offset.js
  • devtools/client/shared/test/browser_html_tooltip_rtl.js
  • devtools/client/shared/test/browser_html_tooltip_variable-height.js

We're only getting the pref value in those tests (https://searchfox.org/firefox-main/search?q=browser.nova.enabled&path=devtools%2Fclient%2Fshared%2Ftest%2F&case=true&regexp=false)

I guess we'd have to cleanup the tests once the pref is effectively removed.

yeah, I'll remove it from this particular meta.

No longer blocks: nova-test-cleanup
Depends on: 2082898
Summary: Remove `browser.nova.enabled=false` coverage from DevTools tooltip tests → Remove `browser.nova.enabled` check in DevTools tooltip tests
You need to log in before you can comment on or make changes to this bug.