Closed
Bug 2082885
Opened 1 month ago
Closed 16 days ago
Remove `browser.nova.enabled=false` coverage from WebExtensions tests
Categories
(WebExtensions :: General, task, P2)
WebExtensions
General
Tracking
(firefox161 fixed)
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: sclements, Assigned: rpl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [addons-jira])
Attachments
(2 external files)
Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.
Tests to clean up:
browser/components/extensions/test/browser/browser_ext_popup_corners.jstoolkit/components/extensions/test/browser/browser_ext_management_themes.jstoolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.jstoolkit/components/extensions/test/browser/browser_ext_themes_dynamic_updates.jstoolkit/components/extensions/test/browser/browser_ext_themes_multiple_backgrounds.jstoolkit/components/extensions/test/browser/browser_ext_themes_pbm.jstoolkit/components/extensions/test/browser/browser_ext_themes_separators.jstoolkit/components/extensions/test/browser/browser_ext_themes_sidebars.jstoolkit/components/extensions/test/browser/browser_ext_themes_toolbar_fields_focus.jstoolkit/components/extensions/test/xpcshell/test_ext_contextual_identities.js
| Assignee | ||
Updated•28 days ago
|
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [addons-jira]
Updated•28 days ago
|
| Assignee | ||
Comment 1•28 days ago
|
||
Updated•28 days ago
|
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•28 days ago
|
||
| Assignee | ||
Comment 3•28 days ago
|
||
Linking as see also Bug 2082884 (as part of which some other mochitests related to contextual identities' Firefox UI are being handled, this bug is only taking care of the WebExtensions APIs side of the contextual identities testing coverage).
See Also: → 2082884
Pushed by luca.greco@alcacoop.it:
https://github.com/mozilla-firefox/firefox/commit/cae94feb75f6
https://hg.mozilla.org/integration/autoland/rev/20b84be67ae6
Remove browser.nova.enabled=false coverage from WebExtensions browser tests. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/57bc04489789
https://hg.mozilla.org/integration/autoland/rev/24f2970240bd
Remove browser.nova.enabled=false coverage from contextual identities xpcshell test. r=baku
https://hg.mozilla.org/mozilla-central/rev/20b84be67ae6
https://hg.mozilla.org/mozilla-central/rev/24f2970240bd
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•