Closed Bug 2082887 Opened 1 month ago Closed 27 days ago

Remove `browser.nova.enabled=false` coverage from toolkit widgets tests

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: sclements, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

toolkit/content/tests/widgets/chrome.toml sets browser.nova.enabled=false for every test in it, and toolkit/content/tests/widgets/chrome-nova.toml duplicates it with the pref set to true. The non-Nova manifest should be removed (or folded into the Nova one), and any nova-conditional skip-if entries revisited.

The Bugbug bot thinks this bug should belong to the 'Toolkit::UI Widgets' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → UI Widgets
See Also: → 2082901
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Whiteboard: [recomp]
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: