Closed Bug 2082904 Opened 1 month ago Closed 18 days ago

Remove `browser.nova.enabled=false` coverage from profiles tests

Categories

(Toolkit :: Startup and Profile System, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: sclements, Assigned: akulyk)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/components/profiles/tests/browser/browser_create_profile_page_test.js

browser/components/profiles/tests/browser/browser-legacy.toml runs the profiles tests with browser.nova.enabled=false and should be removed.

See Also: → 2082901
Whiteboard: [recomp]

A couple more notes here:

  • There are some conditional Nova pref checks that should be cleaned up in /browser/components/profiles/tests/browser/browser_create_profile_page_test.js, for example this one
  • We can remove browser/components/profiles/tests/browser/browser_create_profile_page_test.js and browser_test_current_theme_from_amo.js since they both only run as part of the legacy manifest (the latter is for functionality we no longer support in the new theme picker)
Assignee: nobody → hjones
Assignee: hjones → nobody
Assignee: nobody → akulyk

browser.nova.enabled is about to be locked to true, so the legacy manifest
and the tests for the legacy theme picker are removed.
browser_edit_profile_test.js only ran in the legacy manifest, so its tasks
that don't involve the theme picker move to browser.toml.
Theme selection telemetry is now checked through theme_picker.change,
which the shared picker records.

Status: NEW → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: