Closed Bug 2082905 Opened 1 month ago Closed 19 days ago

Remove `browser.nova.enabled=false` coverage from browser-performance tests

Categories

(Toolkit :: Performance Monitoring, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: sclements, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/base/content/test/browser-performance/head.js
  • browser/base/content/test/browser-performance/browser_startup_flicker.js
  • browser/base/content/test/browser-performance/browser_tabclose.js
  • browser/base/content/test/browser-performance/browser_tabopen.js

browser/base/content/test/browser-performance/browserNova.toml duplicates browser.toml with the pref forced to true and becomes redundant.

See Also: → 2082901

browser.nova.enabled is about to be locked to true.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1f6bcc135217 https://hg.mozilla.org/integration/autoland/rev/ce1a99005ea0 Remove browser.nova.enabled=false coverage from browser-performance tests. r=firefox-desktop-core-reviewers ,Gijs
Status: ASSIGNED → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: