Closed Bug 2082906 Opened 1 month ago Closed 19 days ago

Remove `browser.nova.enabled=false` coverage from popup window tests

Categories

(Firefox :: Site Permissions, task, P1)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: sclements, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-post-nova])

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/base/content/test/browser-popups/browser_popup_new_window_size.js

Emma, is this something you can help with? We're trying to get this in by the end of 161 Nightly.

Flags: needinfo?(emz)

hrm, looks like sfoster added that change to the test. I guess we'll pick this one up.

Flags: needinfo?(emz)
Priority: -- → P1
Whiteboard: [fidefe-post-nova]
Assignee: nobody → kpatenio
Pushed by kpatenio@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5e83396e179c https://hg.mozilla.org/integration/autoland/rev/e93df77b9ecd remove browser.nova.enabled=false coverage in browser_popup_new_window_size.js r=sfoster
Status: NEW → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: