Closed
Bug 2082907
Opened 1 month ago
Closed 19 days ago
Remove `browser.nova.enabled=false` coverage from browser/base tests
Categories
(Firefox :: General, task, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: sclements, Assigned: dgraham)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-post-nova])
Attachments
(1 external file)
Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.
Tests to clean up:
browser/base/content/test/browser-about/browser_aboutSupport_user_namespaces.jsbrowser/base/content/test/browser-maximized/browser_maximized_decoration.js
browser/base/content/test/browser-maximized/browserNova.toml duplicates browser.toml with the pref forced to true and becomes redundant.
| Reporter | ||
Updated•1 month ago
|
Points: --- → 1
Priority: -- → P1
Whiteboard: [fidefe-post-nova]
Updated•1 month ago
|
| Assignee | ||
Updated•25 days ago
|
Assignee: nobody → dgraham
| Assignee | ||
Comment 1•25 days ago
|
||
The browserNova.toml manifest that ran browser_maximized_decoration.js a
second time with Nova enabled was already removed in bug 2082901
Pushed by dgraham@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f39abf3f8eca
https://hg.mozilla.org/integration/autoland/rev/6ff8097ff366
Remove non nova branches from maximized decoration and about:support tests. r=desktop-theme-reviewers,mstriemer
Comment 3•19 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 19 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Updated•6 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•