Closed
Bug 2082908
Opened 1 month ago
Closed 9 days ago
Remove `browser.nova.enabled=false` coverage from about:welcome tests
Categories
(Firefox :: Messaging System, task, P1)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: sclements, Assigned: jprickett, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [omc], OMC_KTLO)
Attachments
(1 external file)
Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.
Tests to clean up:
browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_layout.jsbrowser/components/aboutwelcome/tests/browser/browser_aboutwelcome_navigation.jsbrowser/components/aboutwelcome/tests/browser/browser_aboutwelcome_theming.js
Updated•27 days ago
|
Points: --- → 2
Priority: -- → P1
Whiteboard: [OMC_KTLO]
Updated•20 days ago
|
| Reporter | ||
Comment 1•14 days ago
|
||
Hi, will someone be able to get this patch in by the end of 161 Nightly?
Flags: needinfo?(shughes)
Flags: needinfo?(mjung)
| Assignee | ||
Updated•14 days ago
|
Assignee: nobody → jprickett
| Assignee | ||
Comment 2•10 days ago
|
||
Pushed by jprickett@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/ede298222e97
https://hg.mozilla.org/integration/autoland/rev/17d94031cf60
Remove `browser.nova.enabled=false` coverage from about:welcome tests r=omc-reviewers,yazan,emcminn
Status: NEW → RESOLVED
Closed: 9 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•