Closed Bug 2082908 Opened 1 month ago Closed 9 days ago

Remove `browser.nova.enabled=false` coverage from about:welcome tests

Categories

(Firefox :: Messaging System, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: sclements, Assigned: jprickett, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [omc], OMC_KTLO)

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_layout.js
  • browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_navigation.js
  • browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_theming.js
Points: --- → 2
Priority: -- → P1
Whiteboard: [OMC_KTLO]
Whiteboard: [OMC_KTLO] → [omc], OMC_KTLO

Hi, will someone be able to get this patch in by the end of 161 Nightly?

Flags: needinfo?(shughes)
Flags: needinfo?(mjung)
Assignee: nobody → jprickett
Pushed by jprickett@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ede298222e97 https://hg.mozilla.org/integration/autoland/rev/17d94031cf60 Remove `browser.nova.enabled=false` coverage from about:welcome tests r=omc-reviewers,yazan,emcminn
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Flags: needinfo?(mjung)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: