Closed
Bug 2082910
Opened 1 month ago
Closed 26 days ago
Remove `browser.nova.enabled=false` coverage from sidebar tests
Categories
(Firefox :: Sidebar, task, P1)
Firefox
Sidebar
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: sclements, Assigned: kcochrane)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-postnova])
Attachments
(1 external file)
Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.
Tests to clean up:
browser/components/sidebar/tests/browser/browser_launcher_splitter_expand_on_hover.jsbrowser/components/sidebar/tests/browser/browser_sidebar_expand_on_hover.jsbrowser/components/sidebar/tests/browser/browser_sidebar_pinned_tab_promo.js
Updated•1 month ago
|
| Assignee | ||
Updated•27 days ago
|
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•27 days ago
|
||
Pushed by kcochrane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5feb1e1025ee
https://hg.mozilla.org/integration/autoland/rev/62c130d928c7
Remove browser.nova.enabled=false coverage from sidebar tests r=sidebar-reviewers,jsudiaman
Comment 3•26 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Updated•19 days ago
|
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in
before you can comment on or make changes to this bug.
Description
•