Closed Bug 2082910 Opened 1 month ago Closed 26 days ago

Remove `browser.nova.enabled=false` coverage from sidebar tests

Categories

(Firefox :: Sidebar, task, P1)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: sclements, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-postnova])

Attachments

(1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false or branch on that value need to be removed so only the Nova behavior is tested. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/components/sidebar/tests/browser/browser_launcher_splitter_expand_on_hover.js
  • browser/components/sidebar/tests/browser/browser_sidebar_expand_on_hover.js
  • browser/components/sidebar/tests/browser/browser_sidebar_pinned_tab_promo.js
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5feb1e1025ee https://hg.mozilla.org/integration/autoland/rev/62c130d928c7 Remove browser.nova.enabled=false coverage from sidebar tests r=sidebar-reviewers,jsudiaman
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: