Remove `browser.nova.enabled=false` coverage from Address Bar tests
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: sclements, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng][nova-search-followups])
Attachments
(1 file, 1 external file)
|
69.30 KB,
image/png
|
Details |
Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.
Tests to clean up:
browser/components/urlbar/tests/UrlbarTestUtils.sys.mjsbrowser/components/urlbar/tests/browser-results/browser_tag_star_visibility.jsbrowser/components/urlbar/tests/browser-search/browser_oneOffs_heuristicRestyle.jsbrowser/components/urlbar/tests/browser-searchMode/browser_searchModeSwitcher_basic.jsbrowser/components/urlbar/tests/browser-tabs/browser_switchToTab_chiclet.jsbrowser/components/urlbar/tests/browser-tips/browser_tip_richSuggestion.jsbrowser/components/urlbar/tests/browser-trustPanel/browser_trust_panel.jsbrowser/components/urlbar/tests/browser-UrlbarView/browser_resultDisplay.jsbrowser/components/urlbar/tests/browser-UrlbarView/browser_resultTypes_display.jsbrowser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest.jsbrowser/components/urlbar/tests/unit/test_UrlbarNewTabComponentRegistrant.js
The following browser-proton.toml manifests re-run their directory's browser.toml with browser.nova.enabled=false and should be removed (along with the matching browser-nova.toml duplicates, which become redundant):
browser/components/urlbar/tests/browser-autofill/browser-proton.tomlbrowser/components/urlbar/tests/browser-editing/browser-proton.tomlbrowser/components/urlbar/tests/browser-engagementTelemetry/browser-proton.tomlbrowser/components/urlbar/tests/browser-quickactions/browser-proton.tomlbrowser/components/urlbar/tests/browser-results/browser-proton.tomlbrowser/components/urlbar/tests/browser-search/browser-proton.tomlbrowser/components/urlbar/tests/browser-searchMode/browser-proton.tomlbrowser/components/urlbar/tests/browser-tabs/browser-proton.tomlbrowser/components/urlbar/tests/browser-telemetry/browser-proton.tomlbrowser/components/urlbar/tests/browser-tips/browser-proton.tomlbrowser/components/urlbar/tests/browser-trustPanel/browser-proton.tomlbrowser/components/urlbar/tests/browser-updateResults/browser-proton.tomlbrowser/components/urlbar/tests/browser-UrlbarInput/browser-proton.tomlbrowser/components/urlbar/tests/browser-UrlbarView/browser-proton.tomlbrowser/components/urlbar/tests/browser/browser-proton.tomlbrowser/components/urlbar/tests/browser/searchbar/browser-proton.tomlbrowser/components/urlbar/tests/quicksuggest/browser/browser-proton.toml
Updated•28 days ago
|
| Assignee | ||
Updated•27 days ago
|
| Assignee | ||
Comment 1•27 days ago
|
||
At how bad the Nova looks, Texts harder to read. Icons looks more blurry as before, before was already blurry with the changes to Proton then before.
Some icons are smaller, Folders are not too big.
And you want to remove the way to disable Nova.
Keep both themes or remove Nova.
Updated•21 days ago
|
Updated•21 days ago
|
Comment 4•20 days ago
|
||
| bugherder | ||
Updated•18 days ago
|
Updated•6 days ago
|
Description
•