Closed Bug 2082914 Opened 1 month ago Closed 20 days ago

Remove `browser.nova.enabled=false` coverage from Address Bar tests

Categories

(Firefox :: Address Bar, task, P3)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: sclements, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng][nova-search-followups])

Attachments

(1 file, 1 external file)

Bug 2082898 locks browser.nova.enabled to true. Before that can happen, tests that set the pref to false need to be removed. Do not remove any code behind browser.nova.enabled=false outside of test directories or configuration; that cleanup needs to happen after the pref is locked.

Tests to clean up:

  • browser/components/urlbar/tests/UrlbarTestUtils.sys.mjs
  • browser/components/urlbar/tests/browser-results/browser_tag_star_visibility.js
  • browser/components/urlbar/tests/browser-search/browser_oneOffs_heuristicRestyle.js
  • browser/components/urlbar/tests/browser-searchMode/browser_searchModeSwitcher_basic.js
  • browser/components/urlbar/tests/browser-tabs/browser_switchToTab_chiclet.js
  • browser/components/urlbar/tests/browser-tips/browser_tip_richSuggestion.js
  • browser/components/urlbar/tests/browser-trustPanel/browser_trust_panel.js
  • browser/components/urlbar/tests/browser-UrlbarView/browser_resultDisplay.js
  • browser/components/urlbar/tests/browser-UrlbarView/browser_resultTypes_display.js
  • browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest.js
  • browser/components/urlbar/tests/unit/test_UrlbarNewTabComponentRegistrant.js

The following browser-proton.toml manifests re-run their directory's browser.toml with browser.nova.enabled=false and should be removed (along with the matching browser-nova.toml duplicates, which become redundant):

  • browser/components/urlbar/tests/browser-autofill/browser-proton.toml
  • browser/components/urlbar/tests/browser-editing/browser-proton.toml
  • browser/components/urlbar/tests/browser-engagementTelemetry/browser-proton.toml
  • browser/components/urlbar/tests/browser-quickactions/browser-proton.toml
  • browser/components/urlbar/tests/browser-results/browser-proton.toml
  • browser/components/urlbar/tests/browser-search/browser-proton.toml
  • browser/components/urlbar/tests/browser-searchMode/browser-proton.toml
  • browser/components/urlbar/tests/browser-tabs/browser-proton.toml
  • browser/components/urlbar/tests/browser-telemetry/browser-proton.toml
  • browser/components/urlbar/tests/browser-tips/browser-proton.toml
  • browser/components/urlbar/tests/browser-trustPanel/browser-proton.toml
  • browser/components/urlbar/tests/browser-updateResults/browser-proton.toml
  • browser/components/urlbar/tests/browser-UrlbarInput/browser-proton.toml
  • browser/components/urlbar/tests/browser-UrlbarView/browser-proton.toml
  • browser/components/urlbar/tests/browser/browser-proton.toml
  • browser/components/urlbar/tests/browser/searchbar/browser-proton.toml
  • browser/components/urlbar/tests/quicksuggest/browser/browser-proton.toml
See Also: → 2082901
Severity: -- → N/A
Priority: -- → P3
See Also: → 2071454
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attached image Untitled.png —

At how bad the Nova looks, Texts harder to read. Icons looks more blurry as before, before was already blurry with the changes to Proton then before.
Some icons are smaller, Folders are not too big.

And you want to remove the way to disable Nova.
Keep both themes or remove Nova.

Whiteboard: [sng][nova-search-followups]
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [search][qa-triage-done-c161/b160]
QA Whiteboard: [search][qa-triage-done-c161/b160] → [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: