2082922 - Collect annotations for Android Isolated Processes

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Simon Chopin [:schopin]]

Isolated Processes prevent us from using ptrace to read the crashed process memory, we'll need to update the process_reader crate to use the forked executor instead.

Comment 1

[Simon Chopin [:schopin]]

Interestingly this also hits the desktop case, as YAMA only allows for one process to ptrace() and the remote executor is it.

Comment 2

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - Allow process_reader to read a process through the remote executor. r=#crashreporting-reviewers

Sometimes on Linux we can't use the standard mechanism, and instead must
use the remote executor to read stuff off the crashed process, so we
allow for that in our in-tree process_reader crate.

Comment 3

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - mozannotation_server: add a remote reading annotation primitive r=#crashreporting-reviewers

Expose a new API to retrieve annotations through a remote executor
(represented by a socket), rather than the standard process handle.

Comment 4

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - Have the remote executor serve multiple sessions r=#crashreporting-reviewers

The minidump writer ends its session once the dump is written, but we need
the executor to stay around so that the crash annotations can be read too.

Comment 5

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - Let callers of finalize_crash_report() retrieve the child annotations. r=#crashreporting-reviewers

This lets callers choose how the annotations are read, which will be needed
for processes dumped through the remote executor.

Comment 6

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - Wire through the remote executor to read annotations r=#crashreporting-reviewers

The server keeps its end of the remote executor socket open until the dump
callback returns, so the crash helper can reuse it to read the annotations
once the minidump has been written.

Comment 7

[Simon Chopin [:schopin]]

Attachment: Bug 2082922 - Pick up the minidump-writer remote transport panic fix r=#crashreporting-reviewers

Cherry pick of PR https://github.com/rust-minidump/minidump-writer/pull/248

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ee7dcb94e7c7
https://hg.mozilla.org/integration/autoland/rev/0555b2d04fd4
Pick up the minidump-writer remote transport panic fix r=crashreporting-reviewers,supply-chain-reviewers,afranchuk
https://github.com/mozilla-firefox/firefox/commit/fcd0da65a6d4
https://hg.mozilla.org/integration/autoland/rev/f58c00d967ef
Allow process_reader to read a process through the remote executor. r=crashreporting-reviewers,afranchuk
https://github.com/mozilla-firefox/firefox/commit/29f1fb674a93
https://hg.mozilla.org/integration/autoland/rev/411bde13d267
mozannotation_server: add a remote reading annotation primitive r=crashreporting-reviewers,afranchuk
https://github.com/mozilla-firefox/firefox/commit/36ff9bdcd33d
https://hg.mozilla.org/integration/autoland/rev/ffab1bd25313
Have the remote executor serve multiple sessions r=crashreporting-reviewers,afranchuk
https://github.com/mozilla-firefox/firefox/commit/34ee244c4f1f
https://hg.mozilla.org/integration/autoland/rev/bffab9581640
Let callers of finalize_crash_report() retrieve the child annotations. r=crashreporting-reviewers,afranchuk
https://github.com/mozilla-firefox/firefox/commit/e2d56589eb3c
https://hg.mozilla.org/integration/autoland/rev/2d6eb0fb10d2
Wire through the remote executor to read annotations r=crashreporting-reviewers,geckoview-reviewers,afranchuk,ohall

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0555b2d04fd4
https://hg.mozilla.org/mozilla-central/rev/f58c00d967ef
https://hg.mozilla.org/mozilla-central/rev/411bde13d267
https://hg.mozilla.org/mozilla-central/rev/ffab1bd25313
https://hg.mozilla.org/mozilla-central/rev/bffab9581640
https://hg.mozilla.org/mozilla-central/rev/2d6eb0fb10d2