2083469 - Fix InlineTranslator's handling of reference drawtarget transform in some recorded commands.

Status: ASSIGNED

(Core :: Printing: Output, defect, P2)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2083469 - Fix translator ReferenceDrawTargetTransform handling for PushLayerWithBlend and CreateClippedDrawTarget. r=lsalzman

Since we can replay it with a different transform applied, we can't
quite just record device space bounds.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2083469 - Remove redundant virtual specifiers in DrawTargetRecording.h. r=#gfx-reviewers

Drive-by while I was looking at this.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2083469 - Use SetReferenceDrawTargetTransform for SkGDI fallback. r=lsalzman

Instead of manually passing an offset and downscaling.

We can do it now that handling of that transform is fixed
in the recording.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1531436f01d2
https://hg.mozilla.org/integration/autoland/rev/c9e2f581291e
Fix translator ReferenceDrawTargetTransform handling for PushLayerWithBlend and CreateClippedDrawTarget. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/4ee5bd298855
https://hg.mozilla.org/integration/autoland/rev/ff2cea1aeddc
Remove redundant virtual specifiers in DrawTargetRecording.h. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/f911b573c604
https://hg.mozilla.org/integration/autoland/rev/52a64b433118
Use SetReferenceDrawTargetTransform for SkGDI fallback. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/bb80ca3b402c
https://hg.mozilla.org/integration/autoland/rev/8b1345f2145a
apply code formatting via Lando

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0d4af3c69ea
https://hg.mozilla.org/integration/autoland/rev/f00936a460af
Revert "Bug 2083469: apply code formatting via Lando" for causing reftest and Wr failures

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing reftest and Wr failures

Backout link

Push with failures

Failure log
Failure log
Failure log
Failure log
Failure log
Failure log

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/63869 for changes under testing/web-platform/tests