Open
Bug 2083494
Opened 28 days ago
Updated 22 days ago
Merge commandOverlay, keysetOverlay and popupOverlay into a single overlay for DOMi
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.53? affected)
ASSIGNED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.25)
Attachments
(1 file)
|
16.04 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment both inspector.xul and object.xul load in the three overlays commandOverlay, keysetOverlay and popupOverlay. These are the only two places which load any of these overlays so they might as well be merged into a single overlay.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.25b1pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9664128 -
Flags: review?(frgrahl)
Attachment #9664128 -
Flags: approval-comm-release?
Updated•22 days ago
|
Comment 2•22 days ago
|
||
Comment on attachment 9664128 [details] [diff] [review]
2083494-domi-merge-overlays-25325.patch
lgtm r/a+
Attachment #9664128 -
Flags: review?(frgrahl)
Attachment #9664128 -
Flags: review+
Attachment #9664128 -
Flags: approval-comm-release?
Attachment #9664128 -
Flags: approval-comm-release+
You need to log in
before you can comment on or make changes to this bug.
Description
•