Closed
Bug 2083510
Opened 1 month ago
Closed 1 day ago
Remove the Nova pref check from icon-credit-card-generic.svg
Categories
(Toolkit :: Form Autofill, task)
Toolkit
Form Autofill
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: mtigley, Assigned: kalenlu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxcm-nova])
Attachments
(1 external file)
browser/extensions/formautofill/content/icon-credit-card-generic.svg (the generic credit card icon). The SVG switches between Proton and Nova artwork with an @media -moz-pref("browser.nova.enabled") block. Once the pref is locked:
- remove the
<style>block and the<g class="proton">group; - unwrap
<g class="nova">so its paths sit directly under<svg>; - leave the root
<svg>attributes (fill="context-fill"etc.) as they are.
No tests reference the pref or the Proton artwork.
This is cleanup for after browser.nova.enabled is locked to true (tentatively Firefox 161). It should not land before the lock, so users who had turned Nova off do not get a mix of Proton and Nova artwork.
Updated•1 month ago
|
| Assignee | ||
Comment 1•21 days ago
|
||
Updated•21 days ago
|
Assignee: nobody → klu
Status: NEW → ASSIGNED
Pushed by klu@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/83d452ba82c5
https://hg.mozilla.org/integration/autoland/rev/b7a095af2c2a
Remove the Nova pref check from icon-credit-card-generic.svg. r=mtigley,credential-management-reviewers
Comment 3•1 day ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 day ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•