Open
Bug 2083581
Opened 1 month ago
Updated 9 hours ago
Also check HTTPS endpoint to confirm locked captive portal
Categories
(Core :: Networking, enhancement, P2)
Core
Networking
Tracking
()
REOPENED
People
(Reporter: valentin, Assigned: valentin)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [necko-triaged][necko-priority-next])
Attachments
(1 external file)
Recently I was investigating some captive portal false-positives it seems some captive portals (like iceland air) will keep intercepting plaintext HTTP even after logging in. When looking into the captive portal implementation on Android, it seems they do a follow-up check using HTTPS to confirm the captive portal (see instructions in bug 2078515 comment 3)
We should do the same in our captive portal detector.
| Assignee | ||
Comment 1•1 month ago
|
||
Pushed by valentin.gosu@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/9ac81ad071b4
https://hg.mozilla.org/integration/autoland/rev/68050628b2c9
Also check HTTPS endpoint to confirm locked captive portal r=necko-reviewers,sunil
Pushed by rperta@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a899ce0d0097
https://hg.mozilla.org/integration/autoland/rev/0836dba9a7a2
Revert "Bug 2083581 - Also check HTTPS endpoint to confirm locked captive portal r=necko-reviewers,sunil" for causing xpc failures at /test_ext_captivePortal.js
Backed out for causing xpc failures at /test_ext_captivePortal.js
Backout link
Push with failures
Failure log(s)
Flags: needinfo?(valentin.gosu)
| Assignee | ||
Updated•9 days ago
|
Flags: needinfo?(valentin.gosu)
Pushed by valentin.gosu@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/7750f742b943
https://hg.mozilla.org/integration/autoland/rev/6838ea02564c
Also check HTTPS endpoint to confirm locked captive portal r=necko-reviewers,sunil,extension-reviewers,robwu
Comment 6•22 hours ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 22 hours ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Pushed by asilaghi@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/26bb1513ba39
https://hg.mozilla.org/integration/autoland/rev/648d634a1f84
Revert "Bug 2083581 - Also check HTTPS endpoint to confirm locked captive portal r=necko-reviewers,sunil,extension-reviewers,robwu" at Valentin dev request
Comment 8•11 hours ago
|
||
Backed out at dev request https://hg.mozilla.org/integration/autoland/rev/648d634a1f84
Status: RESOLVED → REOPENED
status-firefox162:
fixed → ---
Resolution: FIXED → ---
Target Milestone: 162 Branch → ---
Pushed by asilaghi@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/41b747af72d9
https://hg.mozilla.org/mozilla-central/rev/617788d3b481
Revert "Bug 2083581 - Also check HTTPS endpoint to confirm locked captive portal r=necko-reviewers,sunil,extension-reviewers,robwu" at Valentin dev request
You need to log in
before you can comment on or make changes to this bug.
Description
•