Closed
Bug 2084018
Opened 27 days ago
Closed 20 days ago
Propagate MediaCodec output buffer release failures
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 3 open bugs)
Details
Attachments
(1 external file)
ReleaseFrameMediaCodec() currently reports success whenever it finds a retained frame, regardless of whether av_mediacodec_release_buffer() succeeds. When a render request fails, the ImageReader can therefore keep waiting for an image that was never submitted, blocking subsequent frame submissions.
Check the MediaCodec return value and propagate failures through the image callback so the ImageReader can clear its pending state. Continue resuming decoder draining whenever a retained frame is removed, including on render failure. Queue that resumption after releasing the frame-map lock.
| Assignee | ||
Updated•27 days ago
|
Assignee: nobody → sotaro.ikeda.g
| Assignee | ||
Comment 1•27 days ago
|
||
Pushed by sikeda.birchill@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1b2ff3341729
https://hg.mozilla.org/integration/autoland/rev/2fe1b4a119cb
Propagate MediaCodec output buffer release failures r=media-playback-reviewers,gfx-reviewers,bradwerth,aosmond
Comment 3•20 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 20 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Updated•7 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•