Closed Bug 2084256 Opened 29 days ago Closed 22 days ago

Remove version 158 train-hop guard for the variant_id and source_section_id extra keys

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Whiteboard: [hnt])

Attachments

(1 external file)

Bug 2070362 added variant_id and source_section_id as extra_keys to the newtab_content impression and click events in Firefox 158. Extra key additions are schema changes in browser/components/newtab/metrics.yaml, which rides the trains and cannot (until recently!) train-hop, and glean-core drops the whole event on an unknown extra key. sanitizeEventData() in lib/NewTabContentPing.sys.mjs therefore deleted both keys when AppConstants.MOZ_APP_VERSION is below 158.0a1.

Firefox 158 reached Release on 2026-10-13 (Nightly is 160), so this can be removed:.

Shim introduced in bug 2070362, threshold corrected in bug 2075682.

Firefox 158 is on Release, so every platform build that can run the newtab XPI has the variant_id and source_section_id extra_keys in its newtab_content schema. Drop the @backward-compat { version 158 } shim in sanitizeEventData() that stripped them on builds older than 158.0a1.

Whiteboard: [hnt]
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2406824d84a6 https://hg.mozilla.org/integration/autoland/rev/74587ff1a90f Remove the version 158 train-hop guard for variant_id and source_section_id in NewTabContentPing. r=ini
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: