Remove version 158 train-hop guard for the variant_id and source_section_id extra keys
Categories
(Firefox :: New Tab Page, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [hnt])
Attachments
(1 external file)
Bug 2070362 added variant_id and source_section_id as extra_keys to the newtab_content impression and click events in Firefox 158. Extra key additions are schema changes in browser/components/newtab/metrics.yaml, which rides the trains and cannot (until recently!) train-hop, and glean-core drops the whole event on an unknown extra key. sanitizeEventData() in lib/NewTabContentPing.sys.mjs therefore deleted both keys when AppConstants.MOZ_APP_VERSION is below 158.0a1.
Firefox 158 reached Release on 2026-10-13 (Nightly is 160), so this can be removed:.
Shim introduced in bug 2070362, threshold corrected in bug 2075682.
Comment 1•29 days ago
|
||
Firefox 158 is on Release, so every platform build that can run the newtab XPI has the variant_id and source_section_id extra_keys in its newtab_content schema. Drop the @backward-compat { version 158 } shim in sanitizeEventData() that stripped them on builds older than 158.0a1.
Updated•29 days ago
|
Updated•28 days ago
|
Updated•28 days ago
|
Comment 3•22 days ago
|
||
| bugherder | ||
Description
•