Closed
Bug 2084567
Opened 26 days ago
Closed 4 days ago
Allow onboarding card buttons to show a leading icon
Categories
(Firefox for Android :: Onboarding, task)
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: corentin, Assigned: corentin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-activation-trust])
Attachments
(1 external file)
Onboarding card buttons can only show text. The new pairing sync card (bug 2068230) needs a QR icon on the primary button. Add an optional leading icon to the onboarding button Action and display it it's available.
The design of the new onboarding card is defined here.
Updated•26 days ago
|
| Assignee | ||
Comment 1•25 days ago
|
||
Onboarding card buttons can only show text, but the new pairing sync card needs a QR icon on its "Scan pairing code" button, before the text.
Add an optional leadingIconRes to the onboarding button Action. Existing buttons are unchanged.
Updated•25 days ago
|
Attachment #9666611 -
Attachment description: WIP: Bug 2084567 - Allow onboarding card buttons to show a leading icon → WIP: Bug 2084567 - Part 1: Allow onboarding card buttons to show a leading icon
Updated•25 days ago
|
Attachment #9666611 -
Attachment description: WIP: Bug 2084567 - Part 1: Allow onboarding card buttons to show a leading icon → Bug 2084567 - Part 1: Allow onboarding card buttons to show a leading icon
| Assignee | ||
Updated•20 days ago
|
Component: Accounts and Sync → Onboarding
Pushed by cbect@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/44876e1b7b73
https://hg.mozilla.org/integration/autoland/rev/215405589c33
Part 1: Allow onboarding card buttons to show a leading icon r=android-reviewers,gmalekpour,twhite
Status: ASSIGNED → RESOLVED
Closed: 4 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•