Closed Bug 2084586 Opened 26 days ago Closed 4 days ago

Add an optional skip button to the onboarding screen

Categories

(Firefox for Android :: Onboarding, task)

All
Android
task
Points:
2

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: corentin, Assigned: corentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-activation-trust])

Attachments

(1 external file)

Add a skip button in the top right corner of the onboarding screen, above the card. It should only be shown for pages that define a skip action. At the moment, no page defines one so existing pages won't change. The new pairing sync card (bug 2068230) will be the first card to have a skip action.

The skip button used to be present in a previous onboarding design version. It may be interesting to look for the old implementation.

The design of the new onboarding card is defined here.

The new pairing sync card needs a Skip button in the top right corner, above the card.

This patch adds an optional onSkipClick to OnboardingPageState. When it is set for the current page, OnboardingContent shows a Skip button above the pager. When it is null, the button is not shown at all.

Attachment #9666798 - Attachment description: WIP: Bug 2084586 - Part 2: Add an optional skip button to the onboarding screen → Bug 2084586 - Part 2: Add an optional skip button to the onboarding screen
Component: Accounts and Sync → Onboarding
No longer blocks: 2068232
Pushed by cbect@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/39a25af4cf2f https://hg.mozilla.org/integration/autoland/rev/c59546d78204 Part 2: Add an optional skip button to the onboarding screen r=android-reviewers,android-l10n-reviewers,twhite,parker
Status: ASSIGNED → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: