Closed Bug 2084753 Opened 28 days ago Closed 22 days ago

Update irregexp's update.py script

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

Attachments

(1 external file)

See Bug 2083707 comment 5 about stale updates via Updatebot

js/src/irregexp/import-irregexp.py, when run on Taskcluster:

  1. uses the V8 copy cloned into the Updatebot docker image when the image was built (/builds/worker/v8),
  2. runs git pull origin master there,
  3. imports whatever that leaves checked out.

Problems:

  • V8's master branch has been frozen since October 25, 2021. Development moved to main, which is what the image's clone checks out. So the pull merges a 2021 commit that's already in that history: "Already up to date".
  • The script never checks out the revision mach asked for. moz.yaml calls import-irregexp.py with no arguments, unlike PDF.js's update.sh, which gets {revision}. mach still records the new revision in moz.yaml.

In taskcluster, import-irregexp.py updated the image's copy of v8 with
git pull origin master, but v8's master branch hasn't moved since 2021, so
it imported v8 as of when the docker image was built while mach recorded the
requested revision in moz.yaml. Updatebot's irregexp updates were therefore
missing whatever had landed upstream since the image was built.

Pass the revision being vendored to the script and fetch exactly that from
the moz.yaml's vendoring url. The temporary-checkout path for local runs does
the same instead of cloning v8's tip.

Assignee: nobody → tom
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: