2084796 - Name the card security code after the card network

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task)

Description

[Micah [:mtigley] (she/her)]

Payment cards name their security code differently: Visa calls it CVV, Mastercard CVC and American Express CID. Firefox currently uses a fixed abbreviation that is also inconsistent ("CVC" in the autocomplete dropdown, "CVV" elsewhere).

Add a helper to CreditCard (toolkit/modules/CreditCard.sys.mjs), next to getNetworkL10nId:

• getSecurityCodeL10n(network) returns the Fluent id and arguments for a new credit-card-security-code-name message that selects on the network: Visa "CVV", Mastercard "CVC", American Express "CID", and "Security code" for any other or unknown network.
• formatSecurityCodeName(network) formats it.

Use it wherever the security code is named:

• the card details in the save/update doorhanger ("… | CVC saved");
• the autocomplete dropdown entry for a security code field;
• the Settings payment methods list and the manage payment methods dialog;
• the security code field in the add/edit payment method dialog, which follows the card number as it is typed ("Security code (optional)" until the network is known).

The affected strings get new ids that take the name as a variable. Their old translations contain a fixed "CVV", so they cannot be migrated.

Tests: test_CreditCard.js for the helper, plus test_profileAutocompleteResult.js, browser_creditCard_doorhanger_cvv.js, browser_editCreditCardDialog_cvv.js, browser_manageCreditCardsDialog_cvv.js, browser_paymentsList_cvv.js and browser_creditCard_cvv.js.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 2084796 - Name the card security code after the card network. r?#credential-management-reviewers,#fluent-reviewers

CreditCard.getSecurityCodeL10n() and formatSecurityCodeName() name the code
the way the card's network does (CVV for Visa, CVC for Mastercard, CID for
American Express, and "Security code" otherwise). The doorhanger card
details, the autocomplete entry, the payment methods list and dialogs, and the
edit dialog's field use it instead of a fixed abbreviation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e1890faf786
https://hg.mozilla.org/integration/autoland/rev/fe86cb275e76
Name the card security code after the card network. r=credential-management-reviewers,fluent-reviewers,dimi,bolsson

Comment 3

[Goloman Adrian[:agoloman]]

Backed out for causing bc failures @browser_creditCard_capture_cvv.js.

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7af7175b265b
https://hg.mozilla.org/integration/autoland/rev/c586fbca0360
Name the card security code after the card network. r=credential-management-reviewers,fluent-reviewers,dimi,bolsson

Comment 5

[rperta]

Backed out for causing bc failures at browser_creditCard_doorhanger_cvv.js
Backout link
Push with failures
Failure log(s)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89dd9e24dd51
https://hg.mozilla.org/integration/autoland/rev/76293ba962ab
Name the card security code after the card network. r=credential-management-reviewers,fluent-reviewers,dimi,bolsson

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/76293ba962ab