Smart window favicons and illustrations ignore Windows high contrast mode
Categories
(Core :: Machine Learning: Frontend, defect)
Tracking
()
| Accessibility Severity | s3 |
People
(Reporter: dao, Unassigned)
References
Details
(Keywords: access, Whiteboard: [aiasst])
Three forced-colors blocks in smart window chrome use @media (forced-colors: active). Browser chrome on Windows runs in the requested state rather than active (see "High contrast mode" in the CSS guidelines), so these rules never apply in Windows high contrast mode:
smartwindowGroupTabs.css,.swgt-favicon: the favicons keep their box shadow and get no outline, so the overlapping edges blur together.smartwindowGroupTabs.css,.swgt-note-art, andagent-monitor-panel.css,.monitor-empty-kit: the illustrations stay visible instead of being hidden.
Using @media (forced-colors) instead covers both states.
Comment 2•28 days ago
|
||
| frontend-triage | ||
Confirmed from the code. All three blocks render in the browser window (chrome). There, Windows high contrast mode sets forced colors to requested, not active (CSS guidelines, "High contrast mode"). So none of the three ever matches:
- smartwindowGroupTabs.css
.swgt-favicon: the shadow-to-outline swap. This sheet is imported by browser-shared.css. The flyout and card are XUL panels in#mainPopupSet, built by AutoTabGrouping.sys.mjs. - smartwindowGroupTabs.css
.swgt-note-art: hideskit-meditating.svg. - agent-monitor-panel.css
.monitor-empty-kit: hidesagent-watch-empty.svg. The panel is a XUL panel created by MonitorPanel.sys.mjs. Line 12 of the same file already uses bare(forced-colors)(bug 2074177), but that fix missed this block.
Fix: change @media (forced-colors: active) to @media (forced-colors) in those three places. Nothing else is needed:
box-shadow: nonemust stay, because therequestedstate doesn't strip shadows.--border-coloralready resolves toCanvasTextunderprefers-contrast, which Windows high contrast mode also matches in chrome.
The other forced-colors: active rules in Smart Window code are correct and should stay. They are in ai-chat-grid, chat-assistant-loader, ai-action-result and ai-action-confirmation, which all render in about:aichatcontent (content), where active does apply.
Tests: nothing checks these rules today. browser_aiwindow_group_tabs_button_interaction.js and browser_aiwindow_monitor_button_panel.js open these panels. browser_forced_colors.js shows how to get the chrome requested state with ui.useAccessibilityTheme=1. A new assertion could follow it and check that .monitor-empty-kit / .swgt-note-art compute display: none on Windows.
Suggested severity: S4. In Windows high contrast mode the group-tabs flyout's overlapping favicons lose their separating outline and two decorative illustrations stay visible. That is cosmetic, and nothing in either panel stops working.
If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.
Needinfo hackbot@mozilla.tld to have a patch generated for this bug, include any questions or directions as needed in your comment.
Updated•25 days ago
|
Comment 3•21 days ago
|
||
The severity field is not set for this bug.
:jlevinsohn, could you have a look please?
For more information, please visit BugBot documentation.
Updated•16 days ago
|
Updated•15 days ago
|
Description
•