208560 - P3P summary only works once

Status: VERIFIED FIXED

(Core :: XML, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Using an old profile, do:

1. Go to URL
2. View > Page Info > Privacy > Summary

Expected results: a summary view

Actual results: a dialog with message "Unable to display privacy summary for
http://www.att.com. Either the site does not have a privacy policy or it could
not be found"

Using a new profile works fine.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Since bug 191920 was blocking1.4 and this is a regression caused by that (or if
you prefer, the patch doesn't actually fix p3p for old profiles), I'm going to
mark this one as blocking too.

Comment 2

[Samir Gehani]

adt: nsbeta1-

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Bug 191920 was only proposed to block 1.4final, it was not approved.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

bug 191920 was not only approved, it landed on the 1.4 branch already.

Comment 5

[harishd]

In an attempt to find the problem I discovered one more BAD problem. The summary
window is populated only once. That's if you click on the summary button the
second time you will get an error message followed by a blank window. This is
very bad and IMO must be fixed for 1.4

Comment 6

[Peter Van der Beken [:peterv]]

Probably needs a xsltp.reset() right before line 62 (xsltp.setParameter("",
"policyUri", policyuri.spec);)

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 125423 [details] [diff] [review]
v1

This fixes the problem with viewing the summary more than once. The change in
Transformiix is needed because otherwise the xsltp.reset() call crashes.

Comment 9

[harishd]

Comment on attachment 125423 [details] [diff] [review]
v1

r=harishd

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 125423 [details] [diff] [review]
v1

I notice this fixes the comment issue as well, thanks.

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Samir, we noticed that this was actually more serious than first thought, so
nominating this again.

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 125423 [details] [diff] [review]
v1

Doh, I wiped out harishd's review, adding it back.

Drivers, this is a low risk fix for 1.4final blocker, requesting approval to
land on 1.4 branch.

Comment 13

[harishd]

Fix checked in on the trunk.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 125423 [details] [diff] [review]
v1

a=asa (on behalf of drivers)for checkin to the 1.4 branch.

Comment 15

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Sent request for ADT approval.

Comment 16

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reserved ADT approval from Rafael and Marina. Ok to land on 1.4 branch.

Comment 17

[Rafael Ebron (:rebron)]

a=adt Please add fixed1.4 keyword after landing on branch

Comment 18

[Samir Gehani]

adt: nsbeta1-

Comment 19

[Peter Van der Beken [:peterv]]

Checked in on branch.

Comment 20

[Paul Wyskoczka]

updating qa contact to [e-mail]

Comment 21

[Grace Bush]

branch build 20030617

Comment 22

[Grace Bush]

verified build 2003120808