Closed Bug 2085777 Opened 25 days ago Closed 14 days ago

Test out appservices-in-tree build mode with a Glean update

Categories

(Data Platform and Tools :: Glean: SDK, task, P1)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janerik, Assigned: janerik)

References

(Blocks 1 open bug)

Details

(Whiteboard: [glean-sdk-jira])

Bug 2085018 gives us the opportunity to run with --enable-appservices-in-tree to test out the required changes.

I started by following our old notes on manually vendoring a Glean Kotlin SDK build: https://mozilla.github.io/glean/dev/android/development-with-mozilla-central.html#try-runs-with-development-versions-of-glean

I did try tasks using:

./mach try fuzzy --full --include-duplicates -q "'appservices-in-tree 'fenix 'test \!ui \!sign"

First run failed: https://treeherder.mozilla.org/jobs?repo=try&revision=be4888466e7b7eb09e4bf11af39883459201fded&selectedTaskRun=GXb6ITEQRIag4Wtj4ODxXg.0
Error: Cannot resolve to a single Glean version.

Adding the same maven URL to appservices and skipping the version checks
Second run: https://treeherder.mozilla.org/jobs?repo=try&revision=f2df8e341bc72382319ff01768f1f1c0c9973c12
Error: Tier 3 tasks fail because glean-sym is wrong.

Fixing up the symbols (that needs to be upstreamed to appservices):
Third run: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=9637ffea6053720fb2e2905b3adeb67271c33bdb
Error: gradle-dependencies -- the packaged dependency cache is incomplete: 4 components absent.

Hacking the script to ignore the Glean dep there
Fourth run: https://treeherder.mozilla.org/jobs?repo=try&revision=353fccfbc3c46a9eb854f0f1296906534ec9405a
Builds work!
Error: Fenix tests fail because libxul is missing


So the build worked, but not the tests.
Here I decided to cut the Glean release and try with that.

Try run against a Glean release with necessary appservices fixes:
https://treeherder.mozilla.org/jobs?repo=try&revision=53d98e3425b45577b23da77af87340c05599b8be

The plain gradle-dependencies still fails (expected).
The gradle-dependencies-appservices task succeeds.
Fenix tests succeed.


Summary: It seems we can run the builds. However the tests don't work as expected, so that might need another look.
Overall our notes on how to manually bundle a Glean SDK still work, but are incomplete.
It's overall a bit hacky and we should provide some scripts to do that work for us instead of manually editing the files.

[dupe]

Blocks: 2090031

The main purpose for this was to test it out and report back to the team.
That happened (in Slack)

Main outcome:

  • Some of those maven { url { hacks might be unnecessary
  • "Glean AARs come from m-c" is of course not covered by the current implementation
  • Maybe at some later point we sync with :ahochheiden and see how we can simplify that
  • :nalexander suggested having Glean Kotlin vendored so it's in the m-c searchfox tree (it's currently separately indexed)
  • Longer term a --glean-in-tree mode could make sense (for testing) -- now that we have experience how to build that
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.