Closed
Bug 208583
Opened 21 years ago
Closed 21 years ago
Remove PerformSubsts from templates
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bbaetz, Assigned: bbaetz)
References
Details
Attachments
(1 file)
|
2.96 KB,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
PerformSubsts will vanish entirely once mail is templatised, but in th meantime
it should be taken out of the templates. This prevents mod_perl, since its
currently in teh global namespace, and its less work to just remove the single
usage than to move the deprecated function.
Also removes pushing SyncShadowDB to the templates now that that function no
longer exists.
|
Assignee | |
Comment 1•21 years ago
|
||
Err, SyncPendingShadowChanges, rather.
I removed the filereceptions entry for the line I'm removing. The new one
doesn't need an entry, since it falls into the 'Param is ok' case.
I also don't think that this is removing any functionality; I can't see much
use for any of the other params (which are the only other substs permitted) in
the my bugs template.
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 125123 [details] [diff] [review]
Patch
nice, simple, etc
Attachment #125123 -
Flags: review?(justdave)
|
||
Updated•21 years ago
|
Attachment #125123 -
Flags: review?(justdave) → review+
|
|
||
Updated•21 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Updated•21 years ago
|
Blocks: bz-globals
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•