Closed Bug 2085844 Opened 24 days ago Closed 23 days ago

Fix whole tree `mach lint` runs on Windows that exceed the command line limit

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement

Tracking

(firefox161 fixed)

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: ahochheiden, Assigned: ahochheiden)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

ruff, eslint and stylelint pass every exclude on the command line, which fails on Windows with WinError 206.

A whole tree run passed 477 excludes in one --extend-exclude
argument of 43226 characters, and Windows refuses a command line over
32767 characters with WinError 206. ruff reads its arguments from an
@file instead, which has no such limit.

Each excluded path became an --ignore-pattern, about 477 on a whole
tree run, which went over the Windows command line limit. The eslint
and stylelint configs already read ThirdPartyPaths.txt and
Generated.txt, so both now get only the global excludes. stylelint
also gets those two files through --ignore-path, because its
ignoreFiles setting does not match a directory line. The patterns now
use forward slashes, so Windows applies them as well. The node
processes no longer start through a shell, which limited the command
line to 8191 characters.

Pushed by ahochheiden@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8a9e4f9d2130 https://hg.mozilla.org/integration/autoland/rev/f734e70f3a58 Part 1 - Pass the ruff arguments through a response file r=linter-reviewers,marco https://github.com/mozilla-firefox/firefox/commit/fff7515d0631 https://hg.mozilla.org/integration/autoland/rev/9fe1d57c7768 Part 2 - Pass eslint and stylelint only the global excludes r=linter-reviewers,marco
Status: NEW → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch

Authored by https://github.com/ahochheiden
https://github.com/mozilla/enterprise-firefox/commit/8a9e4f9d2130e1e8c2d5649d19e129663cd0de8f
[enterprise-main] Bug 2085844 - Part 1 - Pass the ruff arguments through a response file r=linter-reviewers,marco

Authored by https://github.com/ahochheiden
https://github.com/mozilla/enterprise-firefox/commit/fff7515d063105703ad3ab0aa7dc000168d01085
[enterprise-main] Bug 2085844 - Part 2 - Pass eslint and stylelint only the global excludes r=linter-reviewers,marco

(via GitHub webhook, authenticated as shared-secret)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: