Closed
Bug 2085845
Opened 23 days ago
Closed 22 days ago
Split whole tree `mach lint` runs into jobs on Windows
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox161 fixed)
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
On Windows, mach lint . never matches the root path, so each linter runs the whole tree as one job.
| Assignee | ||
Comment 1•23 days ago
|
||
_generate_jobs lists the top level entries only when the linted path
equals self.root. roll passes the path through os.path.abspath,
which gives backslashes on Windows, while mach gives the root with
forward slashes, so on Windows mach lint . ran each linter on the
root as a single job.
Pushed by ahochheiden@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e7027f1b6fef
https://hg.mozilla.org/integration/autoland/rev/454394049f97
Split a whole tree run into jobs on Windows too r=linter-reviewers,marco
Comment 3•22 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 22 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•