Closed
Bug 2085848
Opened 24 days ago
Closed 23 days ago
Resolve the mozcheck binary once per `mach lint` on macOS and Windows
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox161 fixed)
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Spawned workers repeat the mozcheck toolchain lookup, which costs about 3 seconds each.
| Assignee | ||
Comment 1•24 days ago
|
||
On macOS and Windows, each mozlint worker starts a fresh Python process.
The workers did not see the binary setup cached, so every mozcheck
linter ran bootstrap_toolchain again. bootstrap_toolchain takes about
3 seconds per worker, and longer when its cache is cold, since it then
runs mach taskgraph.
Pushed by ahochheiden@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a9e0730edf6e
https://hg.mozilla.org/integration/autoland/rev/01cd7078a41c
Pass the resolved mozcheck binary to mozlint workers r=linter-reviewers,sergesanspaille
Comment 3•23 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 23 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•