Closed
Bug 2085849
Opened 24 days ago
Closed 16 days ago
Speed up `mach_func_cache` validation
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(firefox161 fixed)
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Validating the toolchain task cache reads and hashes about 6000 files on every call.
| Assignee | ||
Comment 1•24 days ago
|
||
Checking whether the cached toolchain tasks are still valid took about
3 seconds on every bootstrap_toolchain call, which mach lint makes
for mozcheck. It read and hashed some 6000 files every time, and walked
mobile/android once for each of the three Gradle globs. The hash of
each file is now kept with its size, modification time and inode, so
unchanged files are not read again, and the <dir>/**/<name> globs that
share a directory are expanded in one walk. The cache key changes shape,
so existing entries miss once.
Pushed by ahochheiden@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5ac3e10c8b62
https://hg.mozilla.org/integration/autoland/rev/2b1b1c79b72a
Hash only the changed inputs in `mach_func_cache` r=linter-reviewers,sylvestre
Comment 3•16 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 16 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•