Closed Bug 2085849 Opened 24 days ago Closed 16 days ago

Speed up `mach_func_cache` validation

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement

Tracking

(firefox161 fixed)

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: ahochheiden, Assigned: ahochheiden)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Validating the toolchain task cache reads and hashes about 6000 files on every call.

Checking whether the cached toolchain tasks are still valid took about
3 seconds on every bootstrap_toolchain call, which mach lint makes
for mozcheck. It read and hashed some 6000 files every time, and walked
mobile/android once for each of the three Gradle globs. The hash of
each file is now kept with its size, modification time and inode, so
unchanged files are not read again, and the <dir>/**/<name> globs that
share a directory are expanded in one walk. The cache key changes shape,
so existing entries miss once.

Status: NEW → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: