Closed Bug 2085854 Opened 22 days ago Closed 12 days ago

Stop linting local tool caches and walking excluded directories

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: ahochheiden, Assigned: ahochheiden)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

Whole tree runs walk .ruff_cache, the other tool caches and objdirs.

mach lint . passes each top level directory to the linters, including
dot directories like .ruff_cache. A walker skips dot entries only below
the directory it starts from, so every whole tree run walked and linted
the tool caches in a local checkout. .ruff_cache alone holds over
250000 files.

The global excludes were merged into each linter's excludes, which
BaseType then replaced with only the excludes inside the linted paths.
A walk outside those paths, like the whole tree walk in
license-declarations, went into every objdir and node_modules.
expand_exclusions now always applies the global excludes unless
filtering is turned off.

A literal exclude now matches an explicitly passed file only by whole
path components, so subdir1/b no longer excludes subdir1/b.js.

Pushed by ahochheiden@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ae29378a9a18 https://hg.mozilla.org/integration/autoland/rev/0d1866a3dfbc Part 1 - Exclude the local cache and scratch directories from every linter r=linter-reviewers,marco https://github.com/mozilla-firefox/firefox/commit/03e4860a3ef3 https://hg.mozilla.org/integration/autoland/rev/779ecac4969b Part 2 - Apply the global excludes to every walk in `expand_exclusions` r=linter-reviewers,sergesanspaille
Status: NEW → RESOLVED
Closed: 12 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: