Reuse "bounce with limit" helper from other places currently using bounce
Categories
(DevTools :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: ochameau, Unassigned)
References
Details
Attachments
(6 external files)
Bug 2028789 started using a better bounce logic for target actors, but this can be used in all places where we are using bounce.
| Reporter | ||
Comment 1•21 days ago
|
||
| Reporter | ||
Comment 2•21 days ago
|
||
| Reporter | ||
Comment 3•20 days ago
•
|
||
Interestingly, I'm hitting the following assertion:
MOZ_DIAGNOSTIC_ASSERT(!mForbiddenToFlush) (This is bad!)
but only when I'm trying to migrate this very specific usage of debounce (and none of the many others!)
https://searchfox.org/firefox-main/rev/d9098b3e11c2fbc2b2d84e53a3c784814cbdab3e/devtools/client/framework/toolbox-hosts.js#287
#onReflow = debounce(() => {
Visible on the following try:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=AW2E8kOiQP2MJPfFfPBWiw.0&revision=b77ab1a0eb01483d1f6a4b36f51f27298642be38
https://treeherder.mozilla.org/logviewer?job_id=602694777&repo=try&task=AW2E8kOiQP2MJPfFfPBWiw.0
And with the following change:
https://phabricator.services.mozilla.com/D337184
| Reporter | ||
Comment 4•20 days ago
|
||
| Reporter | ||
Comment 5•20 days ago
|
||
| Reporter | ||
Comment 6•20 days ago
|
||
| Reporter | ||
Comment 7•20 days ago
|
||
| Reporter | ||
Comment 8•19 days ago
|
||
Perf results for the whole patch queue:
https://perf.compare/subtests-compare-results?baseRev=1a94255c6224ebd5321da6e86be9e83ae65c5f53&baseRepo=try&newRev=edb897197558b27d9e7111f18f61f9a7d12e8c33&newRepo=try&framework=12&baseParentSignature=5716596&newParentSignature=5716596&test_version=mann-whitney-u&sort=median-diff%7Cdesc&initialized=1&filter_status=improvement%2Cregression
Many significant improvements, one significant regression on custom.jsdebugger.project-search.first-search-result.
Description
•