Restore stub-installer test coverage on Windows debug and 64-bit builds
Categories
(Firefox :: Installer, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr153 | --- | unaffected |
| firefox159 | --- | wontfix |
| firefox160 | --- | wontfix |
| firefox161 | --- | fix-optional |
People
(Reporter: spohl, Assigned: spohl)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 external file)
Bug 2074789 appears to have removed existing stub-installer test coverage from Windows debug and 64-bit builds. It made both generation of test_stub_installer.exe and registration of test_stub_installer.js conditional on MOZ_STUB_INSTALLER, which is disabled in those configurations.
Before that change, the test passed on both Windows 64-bit debug and 32-bit debug on mozilla-central push 2036035:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PEuxMFrGS6G30LoRxVfCvw/artifacts/public/test_info/summary.jsonl
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dxpqbQyZQpy2ikbg_uCj-g/artifacts/public/test_info/summary.jsonl
A later Windows 64-bit debug run reports the test group as skipped:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dr9d9hahQneC9Uc1FwOL0Q/artifacts/public/test_info/xpcshell_errorsummary.log
We should restore the test executable and manifest registration for builds with tests enabled, independently of whether they produce a shipping stub installer, while providing the resources the test needs. This concerns lost automated coverage, not a demonstrated defect in the shipping installer.
Test dashboard: https://tests.firefox.dev/test.html?test=browser/installer/windows/nsis/test/xpcshell/test_stub_installer.js
| Assignee | ||
Comment 1•20 days ago
|
||
Build and register the test when tests are enabled, and include the stub branding resources it needs. Non-stub builds with tests disabled continue to omit those resources.
Comment 2•20 days ago
|
||
Set release status flags based on info from the regressing bug 2074789
Updated•18 days ago
|
| Assignee | ||
Updated•14 days ago
|
Description
•